Use def_delegator instead of alias in Queue

zhulik commented 3 years ago

Description

Replace alias with def_delegator in Queue.

Problem: Async::LimitedQueue#<< does not block when the queue is full.

Explanation: both alias and alias_method despite their misleading names do not create aliases, they create full copies of methods with new names. Therefore if one overrides aliased method in a subclass, the alias name still points to the copy of the original base class method. There are 2 ways of dealing with it:

defining aliases manually def new_name(*args, **params) = old_name(*args, **params)
using Forwardable.def_delegator

Check out a gist and a blog post

I'd also recommend replacing aliases everywhere where a class with aliases may potentially be inherited.

Thank you!

Types of Changes

Bug fix.

Testing

[ ] I added tests for my changes.
[X] I tested my changes locally.
[ ] I tested my changes in staging.
[ ] I tested my changes in production.

ioquatix commented 3 years ago

Ohhh this is a terrible bug lol. Okay, I'll fix it.

ioquatix commented 2 years ago

I don't want to introduce forwardable so I've just manually created a proper alias.

socketry / async