Ensure timeout_after yields duration. - Githubissues

socketry / async

An awesome asynchronous event-driven reactor for Ruby.

MIT License

2.14k stars 88 forks source link

Ensure timeout_after yields duration. #149

Closed ioquatix closed 2 years ago

ioquatix commented 2 years ago

Description

As discussed in https://github.com/socketry/async/pull/145

We need to retain backwards compatibility with Async 1 interface with_timeout which is an acceptable middle ground.

Types of Changes

Bug fix.
Breaking change.

Testing

[x] I added tests for my changes.
[x] I tested my changes locally.
[ ] I tested my changes in staging.
[ ] I tested my changes in production.