Fix handling of barriers when waiting on a task fails with an unrelated exception.

socketry / async

An awesome asynchronous event-driven reactor for Ruby.

MIT License

2.09k stars 86 forks source link

Fix handling of barriers when waiting on a task fails with an unrelated exception. #163

Closed ioquatix closed 2 years ago

ioquatix commented 2 years ago

When using a barrier with a timeout, there was a bug where the task would be removed from the task list even though it was still running, causing Barrier#stop to later miss stopping the task and leak it.

Types of Changes

Bug fix.

Testing

[x] I added tests for my changes.
[x] I tested my changes locally.
[ ] I tested my changes in staging.
[ ] I tested my changes in production.

ioquatix commented 2 years ago

Merged by hand.