search

socketry / async

An awesome asynchronous event-driven reactor for Ruby.
MIT License
2.12k stars 86 forks source link

Follow up from fix trasient typo #236

Closed ColinDKelley closed 1 year ago

ColinDKelley commented 1 year ago

Follow-up to "Fix trasient typo" PR.

Types of Changes

Contribution

ioquatix commented 1 year ago

This looks good to me, I've given a few minor feedbacks. We should be clear that the failed state is entered by any kind of unhandled exception.

ioquatix commented 1 year ago

Moving to https://github.com/socketry/async/pull/248 so I can address the feedback before merging.