socketry / cloudflare

An asynchronous Ruby wrapper for the CloudFlare V4 API.
MIT License
139 stars 88 forks source link

CustomHostnames: Add support for the Cloudflare CustomHostname API #36

Closed kallisti5 closed 5 years ago

kallisti5 commented 6 years ago

Working locally for me, but I need to add some rspec stuff. Still nice to have upstreamed for now. :-)

ioquatix commented 5 years ago

I am reworking this code base to use async-rest. Do you think you can rework your PR on top of ne code? Yes, it's a bit of a change and slightly less features, but hopefully we can get feature parity with existing stable release soon.

ioquatix commented 5 years ago

I can't test this feature because it's gated behind having an enterprise level account. I've asked Cloudflare to provide that for testing.

ioquatix commented 5 years ago

This feature has been added by https://github.com/socketry/cloudflare/pull/47