socketry / cloudflare

An asynchronous Ruby wrapper for the CloudFlare V4 API.
138 stars 86 forks source link

Fix purge_cache by specifying a path instead of a `path` parameter #46

Closed knu closed 5 years ago

knu commented 5 years ago

Zone#purge_cache is broken in that it posts to the wrong endpoint zones/:id?path=purge_cache instead of zones/:id/purge_cache. Representation#with does not take a path argument, which could be the root of the problem.

ioquatix commented 5 years ago

Thanks. I will review it when I have time.

knu commented 5 years ago

I've added a call of post and the method should now perform properly. 😅

ioquatix commented 5 years ago

I'm pulling the branch locally so CI can run.

ioquatix commented 5 years ago

Is there any kind of test?

ioquatix commented 5 years ago

Thanks, this is merged.