search

socketry / falcon

A high-performance web server for Ruby, supporting HTTP/1, HTTP/2 and TLS.
https://socketry.github.io/falcon/
MIT License
2.54k stars 79 forks source link

Should the 'virtual' command be changing the Console.logger log level? #222

Closed jakeonfire closed 3 months ago

jakeonfire commented 5 months ago

https://github.com/socketry/falcon/blob/4002aea74988a9b6f5560363eb7738084308152d/lib/falcon/command/virtual.rb#L63

debug is way too noisy in production. (is there a good way to override the Console.logger log level in a rails app?)

jakeonfire commented 5 months ago

adding

Console.logger.level = Console::Logger::LEVELS[:warn]

to falcon.rb works for now. i still don't think it should default to debug, however.

ioquatix commented 5 months ago

Yeah, that's a fair point, not sure what I was thinking at the time - I'll reconsider it.

jakeonfire commented 5 months ago

even changing that line to ENV['CONSOLE_LEVEL'] ||= 'debug' would make it easier to override imo if you have a reason for a default.

ioquatix commented 3 months ago

This is fixed and will be released in the next version bump.