issues
search
socketry
/
io-event
MIT License
66
stars
15
forks
source link
Always #include <ruby.h> before any system header
#89
Closed
eregon
closed
8 months ago
eregon
commented
8 months ago
Fixes
https://github.com/socketry/io-event/issues/88
, the issue explains it in details.
#include "extconf.h"
is redundant and a code smell for missing ruby.h, ruby/internal/config.h already does
#include RUBY_EXTCONF_H
.
Types of Changes
Bug fix.
Contribution
[x] I added tests for my changes.
[x] I tested my changes locally.
[x] I agree to the
Developer's Certificate of Origin 1.1
.
#include "extconf.h"
is redundant and a code smell for missing ruby.h, ruby/internal/config.h already does#include RUBY_EXTCONF_H
.Types of Changes
Contribution