search

socketry / io-event

MIT License
66 stars 15 forks source link

Hanging tests on some platforms #96

Open ahorek opened 7 months ago

ahorek commented 7 months ago

truffleruby, jruby and windows builds hangs here https://github.com/socketry/io-event/blob/main/lib/io/event/selector/select.rb#L173

could it be intentional because of missing WNOHANG support on these platforms? https://github.com/socketry/io-event/pull/95 I'm not familiar with the code around Fibers :)

ioquatix commented 7 months ago

Windows is hanging because in general, non-blocking IO on Windows is inconsistently implemented. We probably need to improve the support in CRuby itself and skip the tests that are failing here.

ahorek commented 7 months ago

skipping broken tests on Windows is fine for me since I don't have any issues with real apps. I was just concerned about failing CI...