search

socketry / multipart-post

Adds multipart POST capability to net/http
MIT License
293 stars 72 forks source link

Error handling frozen outbuf #77

Closed Lewiscowles1986 closed 3 years ago

Lewiscowles1986 commented 3 years ago

Description

Changes error message if outbuf is frozen.

This will not fix internal changing of outbuf to "" (frozen string), but is for notifying consumers of the library about requirements for the arg (if supplied as non-nil)

Types of Changes

Testing

Lewiscowles1986 commented 3 years ago

@ioquatix if you feel very strongly I can close the ticket. It is subjective I guess.

ioquatix commented 3 years ago

I'm generally against adding type checking like this, so given that it does fail predictably, I'm going to close this issue. But I do understand your point of view and appreciate the PR.

The main reason why I'm generally against this is because there are LOTS of places where you could conceivably add checks like this. I'm not sure I have the capacity to judge where and when we should add these explicit checks. Depending on transitive failures and "duck typing" is kind of a Ruby thing, so these checks feel out of place.