UploadIO doesn't work for StringIOs in Ruby 1.9.2

socketry / multipart-post

Adds multipart POST capability to net/http

MIT License

293 stars 72 forks source link

UploadIO doesn't work for StringIOs in Ruby 1.9.2 #8

Open arsduo opened 13 years ago

arsduo commented 13 years ago

In Ruby 1.8.7, StringIO responds to path, but in 1.9.2, it no longer does, which causes UploadIO to break (composite_io.rb:69).

An easy solution would be to check for obj.respond_to? :path ? obj.path : "no local path" (in my tests, supplying a dummy local path seems to work), but I don't know if that causes problems down the line. If not, one of us could write a pull request.

Thanks for the great gem!

Alex

nicksieger commented 13 years ago

Feel free to send a pull request with that change, I'll merge it right away. Thanks for reporting the issue.

ioquatix commented 7 years ago

With the 3.0 release, we will drop support for any ruby < 2.0 so this may no longer be an issue. Do you mind providing a failing test case so we can see if this behaviour still exists?

tnir commented 2 years ago

See #92 for discussion bout supported Ruby versions.