search

socketry / multipart-post

Adds multipart POST capability to net/http
MIT License
293 stars 72 forks source link

Rework file structure & license header. #89

Closed ioquatix closed 2 years ago

ioquatix commented 2 years ago

Tidy up the file structure including require_relative where it makes sense.

Types of Changes

ioquatix commented 2 years ago

@olleolleolle I hope it's sufficient, this gem has a lot of downloads.

texpert commented 2 years ago

Excuse me, but why all these hardcoded warnings' noise in the logs now?

ioquatix commented 2 years ago

Because you updated the gem and we are emitting warnings for files that will eventually be removed because they are clobbering global namespace/paths.

texpert commented 2 years ago

Because you updated the gem and we are emitting warnings for files that will eventually be removed because they are clobbering global namespace/paths.

I understand the primary reason, but then there was https://github.com/socketry/multipart-post/pull/91, where all these constants where deprecated via Object.deprecate_constant, so now the uncoditional warnings are just a bothering noise.

ioquatix commented 2 years ago

The files and the constants they define are two separate issues with separate warnings.

It sounds like you are suggesting to remove the explicit warnings from the files. It's probably better we just fix the dependencies. If you don't want to deal with the warnings, stay with the old versions?