search

socketry / nio4r

Cross-platform asynchronous I/O primitives for scalable network clients and servers.
Other
965 stars 86 forks source link

Need a new Java Release #221

Closed CodingAnarchy closed 5 years ago

CodingAnarchy commented 5 years ago

A patch was made for JRuby deregister errors in #217, but it wasn't released in a new gem version. As puma is using nio4r now, it would really help for that to be released for those of us using JRuby and Puma.

tarcieri commented 5 years ago

We should probably also tackle #220 before another release.

@ioquatix can you take care of these? If not I can when I have some time.

ioquatix commented 5 years ago

It is done.

mperham commented 5 years ago

Gentlemen, nio4r 2.5.1 was pushed today but no associated 2.5.1-java gem release so the gem currently fails to install on jruby.

tarcieri commented 5 years ago

@ioquatix unfortunately every release needs a corresponding -java release, even if the JRuby backend is unchanged. RubyGems handling of platforms is weird that way.

ioquatix commented 5 years ago

Oh my bad that’s my fault. I didn’t imagine it worked like that since 2.5.0 release was okay. Thanks for explaining it, I’ll fix it now.

ioquatix commented 5 years ago

Before we go and reinvent the wheel, is there any existing rake task/library that handles the MRI/JRuby release, e.g.

rake all_platforms:release

For lack of a better place to put it, I threw some notes/instructions here.

tarcieri commented 5 years ago

cc @headius @enebo

Know of any release automations for gems that need a ruby and java release, and also build a JRuby extension for the latter, that can do it all in one go?

enebo commented 5 years ago

@tarcieri I have not seen one but I wish we had a standard for this because I have to read docs whenever I want to build a gem which has java arch.