Closed ioquatix closed 5 years ago
This branch is breaking async
.
koyoko% bundle exec rspec ./spec/async/task_spec.rb:249
/home/samuel/.rvm/gems/ruby-2.6.3/gems/parser-2.6.3.0/lib/parser/lexer.rb:10864: warning: assigned but unused variable - testEof
Run options: include {:locations=>{"./spec/async/task_spec.rb"=>[249]}}
Async::Task
#with_timeout
can extend timeout (FAILED - 1)
Failures:
1) Async::Task#with_timeout can extend timeout
Failure/Error: expect(timer.fires_in).to be_within(10).percent_of(0.1)
expected 0.0016268810024485103 to be within 10% of 0.1
# ./spec/async/task_spec.rb:254:in `block (5 levels) in <top (required)>'
# ./lib/async/reactor.rb:265:in `with_timeout'
# ./spec/async/task_spec.rb:251:in `block (4 levels) in <top (required)>'
# ./lib/async/task.rb:228:in `block in make_fiber'
Finished in 0.21302 seconds (files took 0.18324 seconds to load)
1 example, 1 failure
Failed examples:
rspec ./spec/async/task_spec.rb:249 # Async::Task#with_timeout can extend timeout
It looks like the timeout argument is not being respected?
This branch is breaking async
.
koyoko% bundle exec rspec ./spec/async/task_spec.rb:249
/home/samuel/.rvm/gems/ruby-2.6.3/gems/parser-2.6.3.0/lib/parser/lexer.rb:10864: warning: assigned but unused variable - testEof
Run options: include {:locations=>{"./spec/async/task_spec.rb"=>[249]}}
Async::Task
#with_timeout
can extend timeout (FAILED - 1)
Failures:
1) Async::Task#with_timeout can extend timeout
Failure/Error: expect(timer.fires_in).to be_within(10).percent_of(0.1)
expected 0.0016268810024485103 to be within 10% of 0.1
# ./spec/async/task_spec.rb:254:in `block (5 levels) in <top (required)>'
# ./lib/async/reactor.rb:265:in `with_timeout'
# ./spec/async/task_spec.rb:251:in `block (4 levels) in <top (required)>'
# ./lib/async/task.rb:228:in `block in make_fiber'
Finished in 0.21302 seconds (files took 0.18324 seconds to load)
1 example, 1 failure
Failed examples:
rspec ./spec/async/task_spec.rb:249 # Async::Task#with_timeout can extend timeout
It looks like the timeout argument is not being respected?
Okay, my bad, I missed a backend_poll
call when doing the update.
@ioquatix nice job on the upgrade and release!
Thanks - the JRuby release is still a bit painful - but at least it worked in the end.
@ioquatix wish I would've automated the release process with rake
forever ago. Oh well
Fixes #220