search

socketry / nio4r

Cross-platform asynchronous I/O primitives for scalable network clients and servers.
Other
965 stars 86 forks source link

Ruby head - can't compile on Ubuntu or macOS #299

Closed MSP-Greg closed 1 year ago

MSP-Greg commented 1 year ago

Working with Puma locally, using ruby 3.3.0dev (2023-05-30T15:20:02Z master 1f74e25c3b) [x86_64-linux], flushed some things, ran bundle install, and, just to make my day, nio4r won't compile. Updated my nio4r fork, which ran CI, and the same thing there, as noted below:

Ubuntu 22.04 log macOS 11 log

Have not had time to see what the issue is, I assume it's some change to Ruby, as I'm pretty sure I installed nio4r yesterday...

Hope things are well Greg

MSP-Greg commented 1 year ago

This has been resolved via https://github.com/ruby/ruby/commit/85dcc4866d9f. Verified locally.

It will be several hours before the Ruby builds used with setup-ruby are updated.

Or, the issue will exist on GitHub Actions for several hours.

EDIT: I'll close when the setup-ruby builds have been updated.

ioquatix commented 1 year ago

Thanks for your report, we should definitely be using rb_io_descriptor where possible.. I'll update the code.

MSP-Greg commented 1 year ago

we should definitely be using rb_io_descriptor where possible.. I'll update the code.

Thanks. I started on it, then decided that you could probably do it in your sleep...