search

socketry / nio4r

Cross-platform asynchronous I/O primitives for scalable network clients and servers.
Other
965 stars 86 forks source link

Fix 'Changelog' link with rubygems.org #307

Closed mark-young-atg closed 8 months ago

mark-young-atg commented 8 months ago

On Mac/Firefox and Android/Chrome (I've not tested other platforms) the 'Changelog' link on rubygems.org can be seen to point at CHANGES.md, despite the correct value in lowercase being supplied in the nio4r.gemspec file.

My guess is that rubygems.org insists on uppercasing the change log filename. In nio4r v2.5.9 the changelog file was called CHANGES.md. This got changed with the release of v2.6.0. I've not been able to determine why.

The simplest approach to resolving this and hopefully fixing the 'Changelog' link provided on rubygems.org is to rename from changes.md to CHANGES.md and update the metadata, as done in this PR.

Types of Changes

Contribution

ioquatix commented 8 months ago

The updated gemspec was not published with the lower case changes.md:

image

On the next release, the issue will be fixed.

mark-young-atg commented 8 months ago

Thanks @ioquatix , I failed to spot that. Nice one. All the best, Mark

ioquatix commented 8 months ago

Thanks for raising the issue!