JRuby supports Java 8 and higher. Need to emit Java 8 classfile format

socketry / nio4r

Cross-platform asynchronous I/O primitives for scalable network clients and servers.

Other

966 stars 86 forks source link

JRuby supports Java 8 and higher. Need to emit Java 8 classfile format #317

Closed enebo closed 3 months ago

enebo commented 3 months ago

JRuby supports Java 8 and higher. Need to emit Java 8 classfile format. Addresses #316

Types of Changes

Bug fix.

Contribution

This reverts a change from this last April. Unless there is some GHA action or gem release issue nothing should change other than the classfile format that Java uses to write out its bytecode.

[x] I agree to the Developer's Certificate of Origin 1.1.

ioquatix commented 3 months ago

I believe the reason why I changed this is because it was emitting warnings, but I don't have access to my computer in New Zealand to test as there was a power cut and my desktop shut down (I don't know why it didn't reboot).

I'm happy to merge this, but I can't release it until I'm back in New Zealand in about a week.