Etags: add strong and weak matchers

socketry / protocol-http

MIT License

23 stars 20 forks source link

Etags: add strong and weak matchers #40

Closed zarqman closed 1 year ago

zarqman commented 1 year ago

This adds strong_match? and weak_match? methods to the Etags class for use with If-Match and If-None-Match.

Arguably the existing match? could become an alias to weak_match?, but it could be considered a backwards incompatible change so I've left it as-is. Happy to change if you think it's a good idea.

Types of Changes

New feature.

Contribution

[x] I added tests for my changes.
[x] I tested my changes locally.
[x] I agree to the Developer's Certificate of Origin 1.1.

ioquatix commented 1 year ago

Before we merge this, can you please run bake modernize:license and make sure your name shows up correctly. Thanks!

zarqman commented 1 year ago

bake modernize:license returns ArgumentError: Could not find recipe for modernize:license!. I tried bake list but don't see anything for modernize at all. Do I need to install or run something else first?

ioquatix commented 1 year ago

Ohhh, yes, bundle config --local with maintenance followed by bundle install.

zarqman commented 1 year ago

Alright, I think we're ready?