Invoke close on input stream when input is finished. - Githubissues

socketry / protocol-http

MIT License

23 stars 20 forks source link

Invoke close on input stream when input is finished. #71

Closed ioquatix closed 1 week ago

ioquatix commented 3 weeks ago

After reviewing https://github.com/socketry/async-http/issues/183, I think we should automatically close the input when input is read completely.

Types of Changes

Bug fix.
New feature.

Contribution

[x] I added tests for my changes.
[x] I tested my changes locally.
[x] I agree to the Developer's Certificate of Origin 1.1.

ioquatix commented 1 week ago

At least for the use case we care about, the root cause was fixed here instead: https://github.com/socketry/protocol-rack/commit/b1551156dc71208bd8d30dafe7d86aea57401f20