support 2.3 on CI - Githubissues

socketry / protocol-http1

MIT License

6 stars 14 forks source link

support 2.3 on CI #1

Closed ganmacs closed 5 years ago

ganmacs commented 5 years ago

ref https://github.com/socketry/protocol-http/pull/5#issuecomment-503583836

ganmacs commented 5 years ago

@ioquatix what do you think of this code?

ioquatix commented 5 years ago

I did this in a way which allowed me to keep the code isolated and easy to remove in the future. Thanks for this PR and the related discussion, and your efforts. Please keep it coming!

ioquatix commented 5 years ago

I also reviewed protocol-http and it seems okay, I need to check protocol-http2.