Trailer header name - Githubissues

socketry / protocol-http1

MIT License

6 stars 14 forks source link

Trailer header name #14

Closed orlando-labs closed 3 years ago

orlando-labs commented 3 years ago

Hi, @ioquatix.

Just confused by the usage of trailer headers. RFC names it singular "Trailer" while the constant TRAILER here and TRAILERS here are assigned with plural 'trailers'.

Shouldn't it be "trailer"?

ioquatix commented 3 years ago

Haha, this is great, it looks like I misread something somewhere. You do appear to be completely correct. Thanks for bringing the issue to my attention. It's kind of odd though because I did test this in Chrome at least it seemed to be working!? Maybe I was just seeing what I wanted.

This is an easy fix to I'll push it now.

ioquatix commented 3 years ago

Okay, this was fixed across all the gems. Released in async-http v0.56.0 and falcon v0.38.0.