`eof?` can and does block, so let's avoid it. - Githubissues

socketry / protocol-http1

MIT License

6 stars 14 forks source link

`eof?` can and does block, so let's avoid it. #28

Closed ioquatix closed 10 months ago

ioquatix commented 10 months ago

It turns out that for sockets, eof? can block. In empty? we optimistically care about whether there is data or not, and don't want to block.

See https://bugs.ruby-lang.org/issues/20215 for more context.

Types of Changes

Bug fix.

Contribution

[ ] I added tests for my changes.
[x] I tested my changes locally.
[x] I agree to the Developer's Certificate of Origin 1.1.