search

socketsupply / socket

A cross-platform runtime for Web developers to build desktop & mobile apps for any OS using any frontend library.
https://socketsupply.co/guides
Other
1.63k stars 78 forks source link

sips command not using the scaled values for the size parameters #1004

Closed hypnoshock closed 7 hours ago

hypnoshock commented 7 hours ago

With ios builds, the generated sips command in cli.cc is not using the scaled values therefore not outputting the correct icon sizes

        sipsCommand
          << "sips"
          << " -z " << size << " " << size
          << " " << src
          << " --out " << destFilePath;

fix:

        sipsCommand
          << "sips"
          << " -z " << scaled << " " << scaled
          << " " << src
          << " --out " << destFilePath;
jwerle commented 7 hours ago

@hypnoshock thanks for the find!