socketsupply / tonic

A Low Profile Component Framework – Stable, minimal, easy to audit, zero-dependencies and build-tool-free.
http://tonicframework.dev
MIT License
867 stars 24 forks source link

Remove redundant getter/setter #80

Closed Raynos closed 3 years ago

Raynos commented 3 years ago

I audited the rest of the class where we used .id and relied on the _checkId() logic and there were basically no cases.

The important place where we call _checkId() is assignment to this.state in the getter/setter.

I ended up removing the redundant getter/setter.