search

socketwench / dropwhale

A Drop-in Docker environment for Drupal module testing
GNU Lesser General Public License v3.0
15 stars 2 forks source link

PhantomsJS is dead long live selenium server. #36

Open martinfrances107 opened 6 years ago

martinfrances107 commented 6 years ago

This has been committed to 8.6.x and is RTBC for 8.5.x

https://www.drupal.org/project/drupal/issues/2775653

To quote from the issue

GastonJS is not that much supported and doesn't have a huge user base.

We are using phantomjs, which is not necessarily maintained and stable, especially compared to a headless chrome

In short for long term maintainability I suggest dropwhale needs to sunset phantomjs which will slowly go away.

We need an additional, possibly optional container to hold the selenium-server-standalone process.

port 444 needs to be exposed...as detailed in this change record.

https://www.drupal.org/node/2941464

I am going to develop a PR here as part of the flag modules tentative adoption of this shift in test infrastructure.

martinfrances107 commented 6 years ago

more to follow .. but this seems like a good candidate image/container/process to run

$ docker run -d -p 4444:4444 -v /dev/shm:/dev/shm selenium/standalone-chrome:3.8.1-francium