search

sockjs / sockjs-client

WebSocket emulation - Javascript client
MIT License
8.43k stars 1.3k forks source link

Added esbuild #635

Closed Neizan93 closed 2 months ago

Neizan93 commented 12 months ago

Added ESBuild to fix optimization bailouts on TypeScript frameworks like Angular.

Neizan93 commented 11 months ago

@auvipy it is the ECMAScript Module build with TypeScript types. It is a simple PR to avoid the Angular (and other frameworks) message: "CommonJS or AMD dependencies can cause optimization bailouts" adding the package 'esbuild' with the generated build and types.d.ts for TypeScript usage.

Neizan93 commented 11 months ago

To anyone that needs SockJS Client with TypeScript, Angular or ES Module (ECMAScript Module) y created the package: https://www.npmjs.com/package/@tr0n0s/sockjs-client

auvipy commented 11 months ago

thanks. I will merge it soon. just need to fix the CI from my side

Neizan93 commented 11 months ago

thanks. I will merge it soon. just need to fix the CI from my side

thank you =)

lagoshny commented 2 months ago

@Neizan93 , @auvipy Any news?

lagoshny commented 2 months ago

Great, thank you! @auvipy Can you publish this changes in new lib version?

auvipy commented 2 weeks ago

we got an issue reported here https://github.com/sockjs/sockjs-client/issues/664, can you please fix this? @Neizan93