Hibernate

[rounce]

support for hibernate in cowboy only

[majek]

The patch is fine. But I see no reason not to enable hibernation by default.

Of course, hibernating the processes to often uses too much CPU, maybe the hibernation timeout should be configurable?

By default we could set it to something like 5 seconds (we should remember that heartbeats are sent every 25 seconds).

This approach would also eliminate the need to repeat the ugly "case Hibernate of" all the times.

[rounce]

But I see no reason not to enable hibernation by default.

to preserve the old behaviour. It can be enabled by default later.

Of course, hibernating the processes to often uses too much CPU, maybe the hibernation timeout should be configurable? This approach would also eliminate the need to repeat the ugly "case Hibernate of" all the times.

something like that? https://github.com/rounce/sockjs-erlang/commit/9b5c5948db5032a5b861587a1da53782cb2b5877

[majek]

More like 39f2c8710766d14f2dfa8a5c5e27e0f27dba776d. There are at least three issues with current implementation:

• We do hibernate cowboy websocket process, but we don't hibernate sockjs_session process
• We don't hibernate cowboy xhr processes
• On keepalive (every 25 sec by default) we wake up the ws process and it waits a timeout before going back to sleep.