Hi @rounce - thanks for the patch, and sorry that it has taken this long to look at it. I'm just getting up to speed at the moment, so it'd be good to understand the intent of this patch a bit better. Presumably the goal is to make an idle session hibernate and thus save memory. That sounds sensible to me.
This pull request presents 8 separate commits, some of which are fixes. That will break git bisect if it's merged as is, so can you please squash these down to a single commit (using git rebase -i HEAD~8 or whatever) so that when we merge, we get a nice clean (and bisect-able) history.
Hi @rounce - thanks for the patch, and sorry that it has taken this long to look at it. I'm just getting up to speed at the moment, so it'd be good to understand the intent of this patch a bit better. Presumably the goal is to make an idle session hibernate and thus save memory. That sounds sensible to me.
This pull request presents 8 separate commits, some of which are fixes. That will break
git bisectif it's merged as is, so can you please squash these down to a single commit (usinggit rebase -i HEAD~8or whatever) so that when we merge, we get a nice clean (and bisect-able) history.