sockjs-node fails to get the correct url

sockjs / sockjs-node

WebSocket emulation - Node.js server

http://sockjs.org

MIT License

2.09k stars 309 forks source link

sockjs-node fails to get the correct url #255

Closed Dav0n closed 4 years ago

Dav0n commented 5 years ago

in file "node_modules\webpack-dev-server\client\index.js" line 226: var hostname = urlParts.hostname; <- first evaluate to localhost then to the correct browser url, but keeps failing later with localhost

var protocol = urlParts.protocol; var port = urlParts.port; // check ipv4 and ipv6 all hostname

Dav0n commented 5 years ago

info, i'm starting project with: npm run serve -- --host x.x.x.x --port 9999 firefox keeps reporting: http://localhost:9999/sockjs-node/info?t=1561650441849 <- CORS failed request because i'm not using localhost

brycekahle commented 5 years ago

@Dav0n The line you mentioned is in webpack-dev-server, not sockjs-node. Is the problem there?

brycekahle commented 4 years ago

Closing due to inactivity

Dav0n commented 4 years ago

Sorry didn’t noticed the activity till now, I have seen webpack has a dependency on sockjs, but when passing —host option the parameter does not get to the right place during runtime, maybe it a initialization problem. Greetings