socrata / odn-backend

Backend for the Open Data Network.
Other
9 stars 6 forks source link

EN-37311: GITHUB Vulnerability : HIGH : socrata / odn-backend : handl… #121

Closed ToshMeston closed 4 years ago

ToshMeston commented 4 years ago

…ebars < 4.3.0

Prior to this change

Versions of handlebars prior to 4.0.14 are vulnerable to Prototype Pollution.

Handlebars is being included by instanbul-middleware which is deprecated and no longer being updated. It is a code coverage tool and we only loaded it in the dev environment.

After this change

This change removes instanbul-middleware and its handlebars dependency. It also explicitly adds js-yaml to the package.json, which was missing even though we use it. Instanbul-middleware included js-yaml so it was loading it from there.