socrata / opendatanetwork.com

The Open Data Network
https://www.opendatanetwork.com/
Other
19 stars 12 forks source link

clean up polygon map view #138

Closed zang0 closed 8 years ago

zang0 commented 8 years ago

go to:

http://www.opendatanetwork.com/region/310M200US37980/Philadelphia_Metro_Area_(PA-NJ-DE-MD)

note:

  1. the selected area is difficult to see (purple not fully visible)
  2. city/state names underneath are not visible

i suggest something like:

  1. add significant transparency to all the non selected polygons. let the selected one really pop
  2. replace the purple w/ a much bolder black

To Tosh to work w/ Elizabeth and come up w/ a solution

aaasen commented 8 years ago

You can tweak how polygons display here: https://github.com/socrata/opendatanetwork.com/blob/master/src/maps/constants.js#L45

chrismetcalf commented 8 years ago

Suggestion:

aaasen commented 8 years ago

Did some work on this and looking for feedback. Review app here: https://opendatanetwork-staging-pr-144.herokuapp.com/

ToshMeston commented 8 years ago

I feel like that is a bit better. Having it one color and getting darker when the value increases makes sense to me. Or going from red to green. I think the previous version red to yellow/tan to blue was a little confusing - especially in the middle colors. Is this tan more or less than the yellow? Idk. What you have in the review app looks better.

Is it possible to not have transparency and put the map city and state names on top of the shapes? Also, did you see the PDF Elizabeth mocked up. It's similar to what you have. It's ODN_maps.pdf in the dropbox.

zang0 commented 8 years ago

See last long email thread on this re: feedback.

zang0 commented 8 years ago

any update on this one based on the design convo w/ elizabeth?

aaasen commented 8 years ago

Implement stop light coloring

zang0 commented 8 years ago

Any updates?

aaasen commented 8 years ago

Not yet. I've been working on peers which is close to being complete. I could probably have both of these issues done on Wednesday.

zang0 commented 8 years ago

Great, thanks for the update.

On 1/11/16 6:43 PM, Lane Aasen wrote:

Not yet. I've been working on peers https://github.com/socrata/odn-peers which is close to being complete. I could probably have both of these issues done on Wednesday.

— Reply to this email directly or view it on GitHub https://github.com/socrata/opendatanetwork.com/issues/138#issuecomment-170765391.

spikesc commented 8 years ago

Can I contribute? I'd like to reverse the polygon color ramp.

aaasen commented 8 years ago

Are the colors wrong for some variable?

spikesc commented 8 years ago

I was looking at the ODN maps this morning and wanted to pass along a bit of feedback from my former life as a cartographer. It's a standard practice in map design to use blue colors to represent low values and red to represent high values, think of the standard US Today temperature map (http://images.intellicast.com/WxImages/CustomGraphic/wgfhi.gif). On the ODN maps, the color ramps are reversed with blue representing the highest values and red the lowest. Map design studies have shown that most people are conditioned by years of looking at maps to interpret blue as low and red as high, so with that in mind I'd recommend at some point when you have some spare time in your busy schedule flipping the color ramp. If there's a way I can help, let me know, I'd love to contribute to this project.

aaasen commented 8 years ago

We're working on a new release which improves the map color scheme. See https://opendatanetwork-staging.herokuapp.com/ for the new version.

Sent from my iPhone

On Jan 14, 2016, at 1:53 PM, spikesc notifications@github.com wrote:

I was looking at the ODN maps this morning and wanted to pass along a bit of feedback from my former life as a cartographer. It's a standard practice in map design to use blue colors to represent low values and red to represent high values, think of the standard US Today temperature map (http://images.intellicast.com/WxImages/CustomGraphic/wgfhi.gif). On the ODN maps, the color ramps are reversed with blue representing the highest values and red the lowest. Map design studies have shown that most people are conditioned by years of looking at maps to interpret blue as low and red as high, so with that in mind I'd recommend at some point when you have some spare time in your busy schedule flipping the color ramp. If there's a way I can help, let me know, I'd love to contribute to this project.

— Reply to this email directly or view it on GitHub.

spikesc commented 8 years ago

Nice! The Population, Education, Earnings, and Occupations map colors all look great! Case closed, well done.

aaasen commented 8 years ago

Thanks, glad you like it!

zang0 commented 8 years ago

Requests:

_1 - Can we also restore the Max/Median/Min on the left side? I found that really helpful in knowing what I was looking at.

2 - Having trouble distinguishing state and county boundaries in some scenarios. See: http://opendatanetwork-staging.herokuapp.com/region/0500000US39049/Franklin_County_OH or http://opendatanetwork-staging.herokuapp.com/region/310M200US17140/Cincinnati_Metro_Area(OH-KY-IN) or http://opendatanetwork-staging.herokuapp.com/region/310M200US17140/Cincinnati_Metro_Area_(OH-KY-IN)/education

Can we try fattening and darkening the line on the state boundaries? Perhaps try swapping the state boundary gray for the county boundary black. It should pop out more. @ToshMeston Can you bring in Elizabeth to weigh in here.

aaasen commented 8 years ago

1 - Yes. I'll put max/median/min back but leave out upper and lower quartile. 2 - I can add state borders to the label layer and make them thick so that they are clear on the choropleth.

zang0 commented 8 years ago

i actually like the upper/lower quartiles, any reason not to add them?

aaasen commented 8 years ago

Just that the make the legend larger. I can add them though

Sent from my iPhone

On Jan 15, 2016, at 1:17 PM, zang0 notifications@github.com wrote:

i actually like the upper/lower quartiles, any reason not to add them?

— Reply to this email directly or view it on GitHub.

aaasen commented 8 years ago

Fixed both issues. Note that the state border changes may not show up immediately if map tiles are cached on your browser.

zang0 commented 8 years ago

Last email:

Lets add the transparency to the lower left legend. We have a new problem w/ the intense state and nation boundaries, we can no longer distinguish the selected item. Lane, how long does it take you to make these changes? Can you just get me on a hangout and we go back and forth till we can solve it in 1 session? Hate to keep yanking you around on look and feel stuff.

My current take is:

Elizabeth, please way in if that makes sense.

D.

On 1/16/16 11:25 AM, Elizabeth Rhodes wrote:

I would definitely recommend fattening the state boundaries. Looks like maybe that was a applied in the last day already? I think its working well. The only other thing i would say is maybe reducing the transparency on the colors on the map. Its making it a little more difficult to match it to the scale on the left. If we keep it, perhaps we should apply the transparency to the key as well to make it easier to correlate the two.

On Thu, Jan 14, 2016 at 4:14 PM, Deep Dhillon deep.dhillon@socrata.com wrote:

Hi Elizabeth,

Can you weigh in on ticket 134 issue 2 below.

My comments below.

Thx!
D.

Requests:

_1 - Can we also restore the Max/Median/Min on the left side? I found that really helpful in knowing what I was looking at.

2 - Having trouble distinguishing state and county boundaries in some scenarios. See:http://opendatanetwork-staging.herokuapp.com/region/0500000US39049/Franklin_County_OH orhttp://opendatanetwork-staging.herokuapp.com/region/310M200US17140/Cincinnati_Metro_Area(OH-KY-IN) or http://opendatanetwork-staging.herokuapp.com/region/310M200US17140/Cincinnati_Metro_Area_(OH-KY-IN)/education

Can we try fattening and darkening the line on the state boundaries? Perhaps try swapping the state boundary gray for the county boundary black. It should pop out more. @ToshMeston Can you bring in Elizabeth to weigh in here.
aaasen commented 8 years ago

Added transparency to the lower left legend and dark bars to divide each step of the scale. Thickened the border around the selected region and made it dashed to differentiate it from other borders.

screen shot 2016-01-18 at 10 13 01 pm

Tried changing border colors but it was a bit more work than expected due to layer ordering issues with Leaflet. I could make it work given more time but right now I have quite a bit of school work and I don't want to hold up the release.

zang0 commented 8 years ago

Works for me. Everything looks good. Closing.