soda-inria / sklearn-numba-dpex

Experimental plugin for scikit-learn to be able to run (some estimators) on Intel GPUs via numba-dpex.
BSD 3-Clause "New" or "Revised" License
15 stars 4 forks source link

Hotfix strict convergence check #100

Closed fcharras closed 1 year ago

fcharras commented 1 year ago

Was to eager to merge last PR, tests passed locally, but not in CI, probably due to setup mistake :sweat:

Changes to strict convergence had a small mistake. n_iteration variable must be updated before exiting the loop early.

fcharras commented 1 year ago

updated :ninja:

jjerphan commented 1 year ago

:ninja: