soda-inria / sklearn-numba-dpex

Experimental plugin for scikit-learn to be able to run (some estimators) on Intel GPUs via numba-dpex.
BSD 3-Clause "New" or "Revised" License
15 stars 4 forks source link

FIX fix performance regression seen in `numba_dpex==0.20.0dev3` #104

Closed fcharras closed 1 year ago

fcharras commented 1 year ago

Back to monkey patching :grinning:

Contrary to previous patches for 0.19.0, I can't think of an easy test to check that the patch works or to notify when the patch can be reverted.

I checked that this solves performance issue on edge cloud and the benchmark is still fine locally. (but it doesn't seem to fix the slight added overhead that we've observed locally, but it's not much of an issue).

Link to upstream issue: