soda-inria / sklearn-numba-dpex

Experimental plugin for scikit-learn to be able to run (some estimators) on Intel GPUs via numba-dpex.
BSD 3-Clause "New" or "Revised" License
15 stars 4 forks source link

Fix issues seen on devcloud with flex170 gpu #85

Closed fcharras closed 1 year ago

fcharras commented 1 year ago

For the latter fix it will be interesting to test during the next session on the devcloud if clinfo also fails at finding global_memory_cache_size, else we could use pyopencl.

fcharras commented 1 year ago

TY @jjerphan I've applied your suggestions

I also just noticed while updating the TopK code, that I put wrong numbers in the predicted local memory usage of the kmeans kernels (kmeans++, lloyd and compute_labels), which is needed to run on CPU.

When fixing it I also saw that sometimes SYCL refuses the kernel call if the predicted local memory is too close from the maximum amount of available local memory, so I also ensured to leave a free buffer. (probably that the device itself use it to optimize and load things)

It's a small diff so I took the liberty to hijack it into the last commit.

fcharras commented 1 year ago

TY for review @jjerphan