Soda can't connect to trino using a self-signed certificate

resleal commented 3 months ago

Hi everyone! I'm trying to connect soda to trino but using username and password and a self-signed certificate.

It does not work because there is no parameter "verify" in soda-core-trino [1] that can be passed to python-trino to address this situation [2].

It seems like a simple fix but I don't really know how to submit/contribute on github. That's what I would do:

after line 74 add this: self.verify_ssl = data_source_properties.get("verify_ssl", None)
then after line 98 add this: verify=self.verify_ssl

References: [1] https://github.com/sodadata/soda-core/blob/main/soda/trino/soda/data_sources/trino_data_source.py [2] https://github.com/trinodb/trino-python-client/blob/master/trino/dbapi.py#L187

tools-soda commented 3 months ago

SAS-3131

bastienboutonnet commented 3 months ago

Hi @resleal and thanks for contributing already by opening this issue and proposing a fix.

We would really welcome a pull request from you on this.

In order to contribute to this project with GitHub, we would recommend checking out this documentation page. Basically fork the repo, make your changes, push it to your work and open a PR.

contributing to GitHub projects

iwoork commented 1 month ago

The fixed above worked for me. I think it's worthy of a PR and getting it integrated into the core trino data source.

sodadata / soda-core

Soda can't connect to trino using a self-signed certificate #2046