search

sodadata / soda-core

:zap: Data quality testing for the modern data stack (SQL, Spark, and Pandas) https://www.soda.io
https://go.soda.io/core-docs
Apache License 2.0
1.87k stars 204 forks source link

Bugfix: fix limit in oracle #2055 #2074

Closed DeadNud1e closed 3 months ago

DeadNud1e commented 4 months ago

Fixes the following bug: #2055

Add limit template based on db type. Instead of LIMIT now it uses FETCH FIRST for oracle.

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

m1n0 commented 3 months ago

Thanks for the contrib, I appreciate the refactor to use a method to create the limit statement but this needs to be done a bit more generically on all datasources. I fixed the issue in #2101 and will do such refactor later