Open whummer opened 4 days ago
hi @whummer, thanks for this, it's an interesting use case! It is a minor change and I don't feel like we need to cover it by test, but I see one issue - I would only pass the host/port if value is present, we do not want to force everyone to start specifying host with this change.
Good point, thanks @m1n0 (although I think the Snowflake Python connector would also be able to handle None
values for host
/port
, i.e., if they are not specified by the user).
Updated the PR to pass in keyword arguments (kwargs
) which are only set if values are specified by the user. 👍
Add ability to specify custom
host
/port
for Snowflake connections.Motivation: At LocalStack, we have recently started building a Snowflake emulator that allows running SF queries entirely on the local machine: https://blog.localstack.cloud/2024-05-22-introducing-localstack-for-snowflake/ . As part of building out a repo with sample applications (see here), we are putting together an illustrative Soda application that connects to the local Snowflake emulator (running on
localhost
) and performs various data quality checks.We have been able to get it working already by manually patching the
soda-core
library in the local Pyhon path.... and then:
It would be awesome if this integration was provided by Soda-core out of the box! Looking forward to getting your feedback.
Please let me know where is the best place to add a description for these new attributes (happy to add a short note in the docs), or if this change should be covered by a unit test. Thanks 🙌
/cc @m1n0