search

sodadata / soda-sql

Soda SQL and Soda Spark have been deprecated and replaced by Soda Core. docs.soda.io/soda-core/overview.html
https://docs.soda.io/
Apache License 2.0
59 stars 16 forks source link

Exit with code `2` when tests / monitors fail #156

Open JCZuurmond opened 2 years ago

JCZuurmond commented 2 years ago

Is your feature request related to a problem? Please describe. I would like to differentiate between failing tests and other kind of failures (bugs, connections not working, etc.). This would allow me to have a CI running that does not fail if the test / monitors fail (we get notifications for this via the cloud), but the CI does fail if the Soda scan fails for another reason.

Describe the solution you'd like Exit with code 2 if tests / monitors fail, exit with code 1 for any other failures.

Linked resources Terraform has an option for this.

JCZuurmond commented 2 years ago

Optionally, we could even separate tests and monitors. E.g.: fail with exit code 2 if tests fail, fail with exit code 3 if monitors fail and fail with exit code 1 for any other failure.

vijaykiran commented 2 years ago

I agree, this makes sense. We don't have a clear distinction between monitor failures and test failures though. That can come later.

JCZuurmond commented 2 years ago

@vijaykiran : What will happen with this feature request? I am keen to have this feature in. Created a PR for it almost a year ago, but that one was never merge. Is it going to be in soda-core?