search

sodadata / soda-sql

Soda SQL and Soda Spark have been deprecated and replaced by Soda Core. docs.soda.io/soda-core/overview.html
https://docs.soda.io/
Apache License 2.0
59 stars 16 forks source link

Expose scan_time as part of scanresult #166

Open anilkulkarni87 opened 2 years ago

anilkulkarni87 commented 2 years ago

Is your feature request related to a problem? Please describe. Its a limitation that the scan result doesnt expose the scan time (Time when the scan occurred). This creates an additional step for open source users.

Describe the solution you'd like Add Scan time to the both Merchandise and Test_Result class:

@dataclass
class Measurement:
    metric: str
    column_name: Optional[str] = None
    value: object = None
    group_values: Optional[List[GroupValue]] = None
    scan_time: str
@dataclass
class TestResult:
    test: Test
    passed: bool
    skipped: bool
    values: Optional[dict] = None
    error: Optional[Exception] = None
    group_values: Optional[dict] = None
    scan_time: str

Additional context The current data looks like below: Having the scan_time will be more valuable. image

Soda SQL Version: 2.1.0b20 - Elrond