search

sodadata / soda-sql

Soda SQL and Soda Spark have been deprecated and replaced by Soda Core. docs.soda.io/soda-core/overview.html
https://docs.soda.io/
Apache License 2.0
59 stars 16 forks source link

soda scan error exit 0 #176

Closed cedric-orange closed 2 years ago

cedric-orange commented 2 years ago

Describe the bug When I am running soda scan --offline ./warehouse.yml ./tables/my_table.yml and some tests are in error, command return code is not 1, but 0.

To Reproduce Steps to reproduce the behavior:

  1. Create a new test in scan.yml with a fail test
  2. Run soda scan ...
  3. check return code

Return code should not be 0.

OS: Linux Python Version: Python 3.9.9 Soda SQL Version: Soda CLI version 2.1.1 Warehouse Type: bigquery

vijaykiran commented 2 years ago

Looks like this is caused by @soda_trace wrapper.