sodafoundation / api

SODA Terra Project API module : is an open source implementation of SODA API connecting storage to platforms like Kubernetes, OpenStack, and VMware
Apache License 2.0
828 stars 314 forks source link

Fix for Fileshare acl creation issue #1229

Closed PravinRanjan10 closed 4 years ago

PravinRanjan10 commented 4 years ago

What this PR does / why we need it: There was a CLI issue, we were not able to create ACL for given fileshare using CLI. But we were able to create ACL by using API. For more detail please take a look of #921

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: This PR will allow user to create fileshare acl for given fileshare. Below is the test screen report. acl1

Release note:

codecov[bot] commented 4 years ago

Codecov Report

Merging #1229 into development will decrease coverage by 0.04%. The diff coverage is 100%.

@@               Coverage Diff               @@
##           development    #1229      +/-   ##
===============================================
- Coverage        34.77%   34.72%   -0.05%     
===============================================
  Files               97       97              
  Lines            17652    17664      +12     
===============================================
- Hits              6138     6134       -4     
- Misses           10636    10651      +15     
- Partials           878      879       +1
Impacted Files Coverage Δ
osdsctl/cli/fileshareacl.go 76.59% <100%> (+5.44%) :arrow_up:
pkg/db/drivers/etcd/etcd.go 26.63% <0%> (-0.21%) :arrow_down:
contrib/drivers/huawei/oceanstor/client.go 0% <0%> (ø) :arrow_up:
contrib/drivers/huawei/oceanstor/oceanstor.go 0% <0%> (ø) :arrow_up:
joseph-v commented 4 years ago

LGTM