sodafoundation / api

SODA Terra Project API module : is an open source implementation of SODA API connecting storage to platforms like Kubernetes, OpenStack, and VMware
Apache License 2.0
826 stars 315 forks source link

Fileshare acl has unused metedata field #1313

Open Shruthi-1MN opened 4 years ago

Shruthi-1MN commented 4 years ago

Issue/Feature Description: Bug Why this issue to fixed / feature is needed(give scenarios or use cases): Fileshare acl response body has unused field, that should be removed if not necessary if not then assign proper value to a field It has metadata field, it is kept null even after creation of acl for the file share created

How to reproduce, in case of a bug: 1) Create file share 2) Create acl for the above created file share to access to that particular fileshare with specific access Below are the commands to reproduce

root@root1-HP-EliteBook-840-G2:~/installer/devsds# osdsctl fileshare acl create -a "10.23.25.1" -c "Read,Write" -t "ip" 5d2efd6a-8253-4310-aa26-83154383efaa
+------------------+--------------------------------------+
| Property         | Value                                |
+------------------+--------------------------------------+
| Id               | 6aef6bd7-32d2-49eb-a2b6-9f35a8aa2721 |
| CreatedAt        | 2020-09-21T15:30:16                  |
| TenantId         | e93b4c0934da416eb9c8d120c5d04d96     |
| FileShareId      | 5d2efd6a-8253-4310-aa26-83154383efaa |
| Type             | ip                                   |
| AccessCapability | [Read Write]                         |
| AccessTo         | 10.23.25.1                           |
| Description      |                                      |
| Metadata         | null                                 |
|                  |                                      |
+------------------+--------------------------------------+
root@root1-HP-EliteBook-840-G2:~/installer/devsds# osdsctl fileshare acl list
+--------------------------------------+--------------------------------------+------+------------------+------------+-------------+
| Id                                   | FileShareId                          | Type | AccessCapability | AccessTo   | Description |
+--------------------------------------+--------------------------------------+------+------------------+------------+-------------+
| 6aef6bd7-32d2-49eb-a2b6-9f35a8aa2721 | 5d2efd6a-8253-4310-aa26-83154383efaa | ip   | [Read Write]     | 10.23.25.1 |             |
+--------------------------------------+--------------------------------------+------+------------------+------------+-------------+
root@root1-HP-EliteBook-840-G2:~/installer/devsds#
root@root1-HP-EliteBook-840-G2:~/installer/devsds#
root@root1-HP-EliteBook-840-G2:~/installer/devsds# osdsctl fileshare acl show 6aef6bd7-32d2-49eb-a2b6-9f35a8aa2721
+------------------+--------------------------------------+
| Property         | Value                                |
+------------------+--------------------------------------+
| Id               | 6aef6bd7-32d2-49eb-a2b6-9f35a8aa2721 |
| CreatedAt        | 2020-09-21T15:30:16                  |
| UpdatedAt        | 2020-09-21T15:30:16                  |
| TenantId         | e93b4c0934da416eb9c8d120c5d04d96     |
| FileShareId      | 5d2efd6a-8253-4310-aa26-83154383efaa |
| Type             | ip                                   |
| AccessCapability | [Read Write]                         |
| AccessTo         | 10.23.25.1                           |
| Description      |                                      |
| Metadata         | null                                 |
|                  |                                      |
+------------------+--------------------------------------+

Other Notes / Environment Information: (Please give the env information, log link or any useful information for this issue)