sodafoundation / api

SODA Terra Project API module : is an open source implementation of SODA API connecting storage to platforms like Kubernetes, OpenStack, and VMware
Apache License 2.0
828 stars 314 forks source link

Upgrade go version to 1.18 #1324

Open niladrih opened 2 years ago

niladrih commented 2 years ago

Signed-off-by: Niladri Halder niladri.halder26@gmail.com

What type of PR is this? /kind enhancement

What this PR does / why we need it: This PR upgrades the go version to 1.18 from 1.12. This removes the vendor directory.

Which issue(s) this PR fixes: Fixes #1323

Test Report Added?: /kind NOT-TESTED

Test Report: N/A

Special notes for your reviewer:

SODACODE2022

codecov[bot] commented 2 years ago

Codecov Report

Merging #1324 (2dec741) into master (a689e17) will increase coverage by 0.20%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   38.93%   39.13%   +0.20%     
==========================================
  Files          53       53              
  Lines        6966     9615    +2649     
==========================================
+ Hits         2712     3763    +1051     
- Misses       3739     5337    +1598     
  Partials      515      515              
Impacted Files Coverage Δ
pkg/db/drivers/etcd/client.go 0.00% <ø> (ø)
pkg/utils/urls/urls.go 39.58% <0.00%> (-8.70%) :arrow_down:
client/fake.go 41.76% <0.00%> (-4.10%) :arrow_down:
osdsctl/cli/profile.go 66.66% <0.00%> (-3.55%) :arrow_down:
osdsctl/cli/version.go 59.09% <0.00%> (-3.41%) :arrow_down:
osdsctl/cli/volumeattachment.go 70.51% <0.00%> (-3.26%) :arrow_down:
osdsctl/cli/pool.go 78.57% <0.00%> (-3.25%) :arrow_down:
osdsctl/cli/dock.go 78.04% <0.00%> (-3.21%) :arrow_down:
osdsctl/cli/volumegroup.go 80.64% <0.00%> (-3.14%) :arrow_down:
osdsctl/cli/fileshare.go 80.00% <0.00%> (-3.14%) :arrow_down:
... and 44 more
sushanthakumar commented 2 years ago

@himanshuvar @PravinRanjan10 , pls have a look

sushanthakumar commented 2 years ago

SODACODE-PR-ACCEPTED

This PR is accepted for SODACODE 2022. But merge will be done after appropriate testing as it involves many file changes. Thanks @niladrih for the contribution