search

sodafoundation / delfin

delfin is the SODA Infrastructure Manager project which provides unified, intelligent and scalable resource management, alert and performance monitoring
https://sodafoundation.io/
Apache License 2.0
202 stars 355 forks source link

In push_prometheus_alert function using http protocol can be insecure #874

Open vineela1999 opened 2 years ago

vineela1999 commented 2 years ago

Issue/Feature Description: In delfin/exporter/prometheus/alert_manager.py, In the function definition, def push_prometheus_alert(self, alerts):

try:
                response = requests.post('http://' + host + ":" + port +
                                         '/api/v1/alerts',
                                         json=self.alerts)
                if response.status_code != 200:

here using Http protocol can be insecure

Why this issue to fixed / feature is needed(give scenarios or use cases): Using Http protocol can be insecure . Https can be used instead How to reproduce, in case of a bug:

Other Notes / Environment Information: (Please give the env information, log link or any useful information for this issue)