search

sodafoundation / delfin

delfin is the SODA Infrastructure Manager project which provides unified, intelligent and scalable resource management, alert and performance monitoring
https://sodafoundation.io/
Apache License 2.0
202 stars 355 forks source link

Fixed issue #874 #883

Closed UtkarshShah0 closed 2 years ago

UtkarshShah0 commented 2 years ago

What this PR does / why we need it: In push_prometheus_alert function replaced http with https to make it more secure

Which issue this PR fixes: fixes #874

Special notes for your reviewer: SODACODE 2022 thanks

codecov[bot] commented 2 years ago

Codecov Report

Merging #883 (a575655) into master (795934f) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   70.59%   70.57%   -0.03%     
==========================================
  Files         180      180              
  Lines       18825    18825              
  Branches     2769     2769              
==========================================
- Hits        13289    13285       -4     
- Misses       4694     4695       +1     
- Partials      842      845       +3
Impacted Files Coverage Δ
delfin/exporter/prometheus/alert_manager.py 42.85% <0.00%> (ø)
delfin/drivers/fake_storage/__init__.py 93.63% <0.00%> (-1.02%) :arrow_down: