search

sodafoundation / delfin

delfin is the SODA Infrastructure Manager project which provides unified, intelligent and scalable resource management, alert and performance monitoring
https://sodafoundation.io/
Apache License 2.0
202 stars 355 forks source link

Add a nested comment explaining why fakedriver method is empty #888

Closed joseph-v closed 2 years ago

joseph-v commented 2 years ago

Issue/Feature Description: Add a nested comment explaining why fakedriver method is empty (Eg. reset_connection function) Fix will be to add a comment after pass as below

pass # Fakedriver do not require reset connection

Issues is present in fake driver functions below,

add_trap_config
remove_trap_config
parse_alert
clear_alert

Why this issue to fixed / feature is needed(give scenarios or use cases):

How to reproduce, in case of a bug:

Other Notes / Environment Information: (Please give the env information, log link or any useful information for this issue)

ArjunGK22 commented 2 years ago

Hello Sir,

Can I know in which file the changes has to be made?

joseph-v commented 2 years ago

Hello Sir,

Can I know in which file the changes has to be made?

delfin/drivers/fake_storage/__init__.py