sodafoundation / delfin

delfin is the SODA Infrastructure Manager project which provides unified, intelligent and scalable resource management, alert and performance monitoring
https://sodafoundation.io/
Apache License 2.0
202 stars 355 forks source link

[swagger file update] v1/storages not showing proper output #890

Closed muniraj321 closed 2 years ago

muniraj321 commented 2 years ago

What this PR does / why we need it:

get/v1/storages/access_info is showing "snmp_config" instead of "access_info" and also description also showing snmp_config 1

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

codecov[bot] commented 2 years ago

Codecov Report

Merging #890 (ae3c34b) into master (2e116e9) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
+ Coverage   70.47%   70.49%   +0.01%     
==========================================
  Files         181      181              
  Lines       19055    19055              
  Branches     2812     2812              
==========================================
+ Hits        13429    13432       +3     
+ Misses       4756     4755       -1     
+ Partials      870      868       -2     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 94.40% <0.00%> (+0.76%) :arrow_up:
Navaneetha167 commented 2 years ago

<-----Thanks for sending a pull request-----> This issue can be solved by changing the following code

GET v1/storages/access-infos is showing "snmp_config" instead of "access_infos" in description also it is showing "snmp_config" by using "access_infos" instead of "snmp_config" the issue can be solved.

Screenshot (11)

sushanthakumar commented 2 years ago

This section is about snmp configudation. So here, snmp_configs is correct, does not need to change