search

sodafoundation / delfin

delfin is the SODA Infrastructure Manager project which provides unified, intelligent and scalable resource management, alert and performance monitoring
https://sodafoundation.io/
Apache License 2.0
202 stars 355 forks source link

Replace metric strings with constants. #909

Closed JiuyunZhao closed 2 years ago

JiuyunZhao commented 2 years ago

What this PR does / why we need it: We should use unified naming constants. Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

codecov[bot] commented 2 years ago

Codecov Report

Merging #909 (5061c9a) into master (9c4edcd) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   71.36%   71.36%           
=======================================
  Files         182      182           
  Lines       21398    21400    +2     
  Branches     3271     3271           
=======================================
+ Hits        15270    15272    +2     
  Misses       5096     5096           
  Partials     1032     1032
Impacted Files Coverage Δ
delfin/api/schemas/storage_capabilities_schema.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 94.41% <100.00%> (+0.01%) :arrow_up: