sodafoundation / delfin

delfin is the SODA Infrastructure Manager project which provides unified, intelligent and scalable resource management, alert and performance monitoring
https://sodafoundation.io/
Apache License 2.0
202 stars 355 forks source link

svc 3par vnx controller add cpu count #960

Closed amanr032 closed 1 year ago

amanr032 commented 1 year ago

What this PR does / why we need it: This PR adds additional field, cpu_count to supported drivers

Which issue this PR fixes(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)*: fixes #

The PR https://github.com/sodafoundation/delfin/pull/940 not permitting rebase. This PR is to rebase and merge https://github.com/sodafoundation/delfin/pull/940 using same commits. When this PR gets merged, the PR https://github.com/sodafoundation/delfin/pull/940 will be closed

Special notes for your reviewer:

Release note:

codecov[bot] commented 1 year ago

Codecov Report

Merging #960 (03d94dc) into master (f2553bd) will decrease coverage by 0.01%. The diff coverage is 68.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #960 +/- ## ========================================== - Coverage 70.56% 70.54% -0.02% ========================================== Files 192 192 Lines 23205 23217 +12 Branches 3568 3570 +2 ========================================== + Hits 16374 16378 +4 - Misses 5712 5716 +4 - Partials 1119 1123 +4 ``` | [Impacted Files](https://codecov.io/gh/sodafoundation/delfin/pull/960?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation) | Coverage Δ | | |---|---|---| | [delfin/drivers/fujitsu/eternus/eternus\_stor.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvZnVqaXRzdS9ldGVybnVzL2V0ZXJudXNfc3Rvci5weQ==) | `88.81% <ø> (ø)` | | | [delfin/drivers/hpe/hpe\_3par/ssh\_handler.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvaHBlL2hwZV8zcGFyL3NzaF9oYW5kbGVyLnB5) | `78.74% <54.54%> (-1.26%)` | :arrow_down: | | [...rivers/dell\_emc/vnx/vnx\_block/component\_handler.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvZGVsbF9lbWMvdm54L3ZueF9ibG9jay9jb21wb25lbnRfaGFuZGxlci5weQ==) | `64.08% <66.66%> (+0.01%)` | :arrow_up: | | [delfin/drivers/hpe/hpe\_msa/ssh\_handler.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvaHBlL2hwZV9tc2Evc3NoX2hhbmRsZXIucHk=) | `66.79% <66.66%> (-0.01%)` | :arrow_down: | | [delfin/drivers/hpe/hpe\_3par/component\_handler.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvaHBlL2hwZV8zcGFyL2NvbXBvbmVudF9oYW5kbGVyLnB5) | `74.50% <100.00%> (+0.12%)` | :arrow_up: | | [delfin/drivers/hpe/hpe\_3par/consts.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvaHBlL2hwZV8zcGFyL2NvbnN0cy5weQ==) | `100.00% <100.00%> (ø)` | | | [delfin/drivers/ibm/storwize\_svc/ssh\_handler.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvaWJtL3N0b3J3aXplX3N2Yy9zc2hfaGFuZGxlci5weQ==) | `74.15% <100.00%> (+0.03%)` | :arrow_up: | | [delfin/drivers/fake\_storage/\_\_init\_\_.py](https://codecov.io/gh/sodafoundation/delfin/pull/960/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvZmFrZV9zdG9yYWdlL19faW5pdF9fLnB5) | `94.05% <0.00%> (-0.26%)` | :arrow_down: |
skdwriting commented 1 year ago

Please add proper PR description and information before merging it. @amanr032 @joseph-v