sodafoundation / delfin

delfin is the SODA Infrastructure Manager project which provides unified, intelligent and scalable resource management, alert and performance monitoring
https://sodafoundation.io/
Apache License 2.0
202 stars 354 forks source link

unity change ethport's logictype and THROUGHPUT'units as Ki #999

Open tanjiangyu-ghca opened 1 year ago

tanjiangyu-ghca commented 1 year ago

What this PR does / why we need it: unity change ethport's logictype and THROUGHPUT'units as Ki

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

codecov[bot] commented 1 year ago

Codecov Report

Merging #999 (1d1ab3f) into master (f2765e1) will increase coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #999 +/- ## ========================================== + Coverage 70.83% 70.85% +0.01% ========================================== Files 195 195 Lines 23987 23994 +7 Branches 3674 3677 +3 ========================================== + Hits 16991 17000 +9 + Misses 5831 5830 -1 + Partials 1165 1164 -1 ``` | [Impacted Files](https://app.codecov.io/gh/sodafoundation/delfin/pull/999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation) | Coverage Δ | | |---|---|---| | [delfin/drivers/dell\_emc/unity/rest\_handler.py](https://app.codecov.io/gh/sodafoundation/delfin/pull/999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvZGVsbF9lbWMvdW5pdHkvcmVzdF9oYW5kbGVyLnB5) | `44.66% <ø> (ø)` | | | [delfin/drivers/dell\_emc/unity/consts.py](https://app.codecov.io/gh/sodafoundation/delfin/pull/999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvZGVsbF9lbWMvdW5pdHkvY29uc3RzLnB5) | `100.00% <100.00%> (ø)` | | | [delfin/drivers/dell\_emc/unity/unity.py](https://app.codecov.io/gh/sodafoundation/delfin/pull/999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvZGVsbF9lbWMvdW5pdHkvdW5pdHkucHk=) | `68.38% <100.00%> (+0.57%)` | :arrow_up: | | [delfin/drivers/ibm/storwize\_svc/ssh\_handler.py](https://app.codecov.io/gh/sodafoundation/delfin/pull/999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sodafoundation#diff-ZGVsZmluL2RyaXZlcnMvaWJtL3N0b3J3aXplX3N2Yy9zc2hfaGFuZGxlci5weQ==) | `74.15% <100.00%> (ø)` | |
JiuyunZhao commented 1 year ago

LGTM